refactor(update-config): move logic to config model

packages/backend/src/controllers/api/v1/admin/config/update.ee.js

@@ -4,35 +4,8 @@ import Config from '../../../../../models/config.js';
 
 export default async (request, response) => {
   const config = configParams(request);
-  const configKeys = Object.keys(config);
-  const updates = [];
 
-  for (const key of configKeys) {
+  await Config.batchUpdate(config);
-    const newValue = config[key];
-
-    if (newValue) {
-      const entryUpdate = Config.query()
-        .insert({
-          key,
-          value: {
-            data: newValue,
-          },
-        })
-        .onConflict('key')
-        .merge({
-          value: {
-            data: newValue,
-          },
-        });
-
-      updates.push(entryUpdate);
-    } else {
-      const entryUpdate = Config.query().findOne({ key }).delete();
-      updates.push(entryUpdate);
-    }
-  }
-
-  await Promise.all(updates);
 
   renderObject(response, config);
 };

packages/backend/src/models/config.js

@@ -15,14 +15,14 @@ class Config extends Base {
   };
 
   static async isInstallationCompleted() {
-    const installationCompletedEntry = await this
+    const installationCompletedEntry = await this.query()
-      .query()
       .where({
-        key: 'installation.completed'
+        key: 'installation.completed',
       })
       .first();
 
-    const installationCompleted = installationCompletedEntry?.value?.data === true;
+    const installationCompleted =
+      installationCompletedEntry?.value?.data === true;
 
     return installationCompleted;
   }
@@ -35,6 +35,38 @@ class Config extends Base {
       },
     });
   }
+
+  static async batchUpdate(config) {
+    const configKeys = Object.keys(config);
+    const updates = [];
+
+    for (const key of configKeys) {
+      const newValue = config[key];
+
+      if (newValue) {
+        const entryUpdate = Config.query()
+          .insert({
+            key,
+            value: {
+              data: newValue,
+            },
+          })
+          .onConflict('key')
+          .merge({
+            value: {
+              data: newValue,
+            },
+          });
+
+        updates.push(entryUpdate);
+      } else {
+        const entryUpdate = Config.query().findOne({ key }).delete();
+        updates.push(entryUpdate);
+      }
+    }
+
+    return await Promise.all(updates);
+  }
 }
 
 export default Config;