chore: address review comments

packages/backend/src/apps/stripe/triggers/balance-transaction/get-balance-transactions.ts

@@ -0,0 +1,32 @@
+import {IGlobalVariable, IJSONObject} from "@automatisch/types";
+import {URLSearchParams} from "url";
+import {isEmpty, omitBy} from "lodash";
+
+const getBalanceTransactions = async ($: IGlobalVariable) => {
+  let response;
+  let lastId = undefined;
+
+  do {
+    const params: IJSONObject = {
+      starting_after: lastId,
+      ending_before: $.flow.lastInternalId
+    }
+    const queryParams = new URLSearchParams(omitBy(params, isEmpty))
+    const requestPath = `/v1/balance_transactions${
+      queryParams.toString() ? `?${queryParams.toString()}` : ''
+    }`;
+
+    response = (await $.http.get(requestPath)).data
+    for (const entry of response.data) {
+      $.pushTriggerItem({
+        raw: entry,
+        meta: {
+          internalId: entry.id as string
+        }
+      })
+      lastId = entry.id
+    }
+  } while (response.has_more)
+};
+
+export default getBalanceTransactions;

packages/backend/src/apps/stripe/triggers/balance-transaction/index.ts

@@ -1,12 +1,12 @@
 import defineTrigger from "../../../../helpers/define-trigger";
-import getBalanceTransactions from "../../common/get-balance-transactions";
+import getBalanceTransactions from "./get-balance-transactions";
 
 export default defineTrigger({
-    name: 'Balance Transaction',
-    key: 'balanceTransaction',
-    description: 'Triggers when a new transaction is processed (refund, payout, adjustment, ...)',
-    pollInterval: 15,
-    async run($) {
-        await getBalanceTransactions($)
-    }
+  name: 'New Balance Transactions',
+  key: 'balanceTransaction',
+  description: 'Triggers when a new transaction is processed (refund, payout, adjustment, ...)',
+  pollInterval: 15,
+  async run($) {
+    await getBalanceTransactions($)
+  }
 })

packages/backend/src/apps/stripe/triggers/payouts/get-payouts.ts

@@ -0,0 +1,32 @@
+import {IGlobalVariable, IJSONObject} from "@automatisch/types";
+import {URLSearchParams} from "url";
+import {isEmpty, omitBy} from "lodash";
+
+const getPayouts = async ($: IGlobalVariable) => {
+  let response;
+  let lastId = undefined;
+
+  do {
+    const params: IJSONObject = {
+      starting_after: lastId,
+      ending_before: $.flow.lastInternalId
+    }
+    const queryParams = new URLSearchParams(omitBy(params, isEmpty))
+    const requestPath = `/v1/payouts${
+      queryParams.toString() ? `?${queryParams.toString()}` : ''
+    }`;
+
+    response = (await $.http.get(requestPath)).data
+    for (const entry of response.data) {
+      $.pushTriggerItem({
+        raw: entry,
+        meta: {
+          internalId: entry.id as string
+        }
+      })
+      lastId = entry.id
+    }
+  } while (response.has_more)
+};
+
+export default getPayouts;

packages/backend/src/apps/stripe/triggers/payouts/index.ts

@@ -1,12 +1,12 @@
 import defineTrigger from "../../../../helpers/define-trigger";
-import getPayouts from "../../common/get-payouts";
+import getPayouts from "./get-payouts";
 
 export default defineTrigger({
-    name: 'Payout',
-    key: 'payout',
-    description: 'Triggers when a payout (Stripe <-> Bank account) has been updated',
-    pollInterval: 15,
-    async run($) {
-        await getPayouts($)
-    }
+  name: 'New Payouts',
+  key: 'payout',
+  description: 'Triggers when a payout (Stripe <-> Bank account) has been updated',
+  pollInterval: 15,
+  async run($) {
+    await getPayouts($)
+  }
 })