From 3408be2840f2ccf3f5a4dcfabab74f848e226140 Mon Sep 17 00:00:00 2001 From: "Jakub P." Date: Thu, 19 Sep 2024 00:17:05 +0200 Subject: [PATCH] test: search for proper snackbar on user create error --- packages/e2e-tests/tests/admin/manage-users.spec.js | 11 ++--------- packages/web/src/locales/en.json | 1 + packages/web/src/pages/CreateUser/index.jsx | 8 ++++++++ 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/packages/e2e-tests/tests/admin/manage-users.spec.js b/packages/e2e-tests/tests/admin/manage-users.spec.js index 80ebfc07..d6fc1507 100644 --- a/packages/e2e-tests/tests/admin/manage-users.spec.js +++ b/packages/e2e-tests/tests/admin/manage-users.spec.js @@ -156,15 +156,8 @@ test.describe('User management page', () => { 'option', { name: 'Admin' } ).click(); await adminCreateUserPage.createButton.click(); - await adminUsersPage.snackbar.waitFor({ - state: 'attached' - }); - /* - TODO: assert snackbar behavior after deciding what should - happen here, i.e. if this should create a new user, stay the - same, un-delete the user, or something else - */ - // await adminUsersPage.getSnackbarData('snackbar-error'); + const snackbar = await adminUsersPage.getSnackbarData('snackbar-error'); + await expect(snackbar.variant).toBe('error'); await adminUsersPage.closeSnackbar(); } ); diff --git a/packages/web/src/locales/en.json b/packages/web/src/locales/en.json index d4f9592a..95576fde 100644 --- a/packages/web/src/locales/en.json +++ b/packages/web/src/locales/en.json @@ -223,6 +223,7 @@ "createUser.submit": "Create", "createUser.successfullyCreated": "The user has been created.", "createUser.invitationEmailInfo": "Invitation email will be sent if SMTP credentials are valid. Otherwise, you can share the invitation link manually: ", + "createUser.error": "Error while creating the user", "editUserPage.title": "Edit user", "editUser.status": "Status", "editUser.submit": "Update", diff --git a/packages/web/src/pages/CreateUser/index.jsx b/packages/web/src/pages/CreateUser/index.jsx index d3b323ff..42abe936 100644 --- a/packages/web/src/pages/CreateUser/index.jsx +++ b/packages/web/src/pages/CreateUser/index.jsx @@ -51,6 +51,14 @@ export default function CreateUser() { }, }); } catch (error) { + enqueueSnackbar(formatMessage('createUser.error'), { + variant: 'error', + persist: true, + SnackbarProps: { + 'data-test': 'snackbar-error', + }, + }); + throw new Error('Failed while creating!'); } };