From 3308a44c2b2e294595e9070d258b446d055261aa Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Fri, 28 Oct 2022 00:41:23 +0200 Subject: [PATCH] refactor: Remove testRun and completion check from new stargazers --- .../src/apps/github/triggers/new-stargazers/index.ts | 6 ------ .../apps/github/triggers/new-stargazers/new-stargazers.ts | 5 +---- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/backend/src/apps/github/triggers/new-stargazers/index.ts b/packages/backend/src/apps/github/triggers/new-stargazers/index.ts index 5584e022..7ebfda63 100644 --- a/packages/backend/src/apps/github/triggers/new-stargazers/index.ts +++ b/packages/backend/src/apps/github/triggers/new-stargazers/index.ts @@ -43,10 +43,4 @@ export default defineTrigger({ async run($) { await newStargazers($); }, - - sort(stargazerA, stargazerB) { - return ( - Number(stargazerB.meta.internalId) - Number(stargazerA.meta.internalId) - ); - }, }); diff --git a/packages/backend/src/apps/github/triggers/new-stargazers/new-stargazers.ts b/packages/backend/src/apps/github/triggers/new-stargazers/new-stargazers.ts index e34e819e..2dab3f55 100644 --- a/packages/backend/src/apps/github/triggers/new-stargazers/new-stargazers.ts +++ b/packages/backend/src/apps/github/triggers/new-stargazers/new-stargazers.ts @@ -48,9 +48,6 @@ const newStargazers = async ($: IGlobalVariable) => { const { starred_at, user } = starEntry; const timestamp = DateTime.fromISO(starred_at).toMillis(); - if (timestamp <= Number($.flow.lastInternalId) && !$.execution.testRun) - return; - const dataItem = { raw: user, meta: { @@ -61,7 +58,7 @@ const newStargazers = async ($: IGlobalVariable) => { $.pushTriggerItem(dataItem); } } - } while (pathname && !$.execution.testRun); + } while (pathname); }; export default newStargazers;