From 2b6ff7de417cb16e9c512be1f203b30df1694465 Mon Sep 17 00:00:00 2001
From: Faruk AYDIN <omerfaruk26@gmail.com>
Date: Fri, 28 Oct 2022 13:23:51 +0200
Subject: [PATCH] refactor: Remove dedupeStrategy field from triggers

---
 .../apps/flickr/triggers/new-albums/index.ts  |  7 +++----
 .../triggers/new-favorite-photos/index.ts     |  7 +++----
 .../triggers/new-photos-in-album/index.ts     | 19 +++++++++----------
 .../apps/flickr/triggers/new-photos/index.ts  |  7 +++----
 .../github/triggers/new-watchers/index.ts     |  1 -
 .../triggers/new-follower-of-me/index.ts      |  1 -
 packages/types/index.d.ts                     |  1 -
 7 files changed, 18 insertions(+), 25 deletions(-)

diff --git a/packages/backend/src/apps/flickr/triggers/new-albums/index.ts b/packages/backend/src/apps/flickr/triggers/new-albums/index.ts
index 57737f27..fd92a9c5 100644
--- a/packages/backend/src/apps/flickr/triggers/new-albums/index.ts
+++ b/packages/backend/src/apps/flickr/triggers/new-albums/index.ts
@@ -6,16 +6,15 @@ export default defineTrigger({
   pollInterval: 15,
   key: 'new-albums',
   description: 'Triggers when you create a new album.',
-  dedupeStrategy: 'greatest',
   substeps: [
     {
       key: 'chooseConnection',
-      name: 'Choose connection'
+      name: 'Choose connection',
     },
     {
       key: 'testStep',
-      name: 'Test trigger'
-    }
+      name: 'Test trigger',
+    },
   ],
 
   async run($) {
diff --git a/packages/backend/src/apps/flickr/triggers/new-favorite-photos/index.ts b/packages/backend/src/apps/flickr/triggers/new-favorite-photos/index.ts
index 2647c910..3ae20938 100644
--- a/packages/backend/src/apps/flickr/triggers/new-favorite-photos/index.ts
+++ b/packages/backend/src/apps/flickr/triggers/new-favorite-photos/index.ts
@@ -6,16 +6,15 @@ export default defineTrigger({
   pollInterval: 15,
   key: 'newFavoritePhotos',
   description: 'Triggers when you favorite a photo.',
-  dedupeStrategy: 'unique',
   substeps: [
     {
       key: 'chooseConnection',
-      name: 'Choose connection'
+      name: 'Choose connection',
     },
     {
       key: 'testStep',
-      name: 'Test trigger'
-    }
+      name: 'Test trigger',
+    },
   ],
 
   async run($) {
diff --git a/packages/backend/src/apps/flickr/triggers/new-photos-in-album/index.ts b/packages/backend/src/apps/flickr/triggers/new-photos-in-album/index.ts
index 340b83c2..b5332df1 100644
--- a/packages/backend/src/apps/flickr/triggers/new-photos-in-album/index.ts
+++ b/packages/backend/src/apps/flickr/triggers/new-photos-in-album/index.ts
@@ -6,11 +6,10 @@ export default defineTrigger({
   pollInterval: 15,
   key: 'newPhotosInAlbum',
   description: 'Triggers when you add a new photo in an album.',
-  dedupeStrategy: 'greatest',
   substeps: [
     {
       key: 'chooseConnection',
-      name: 'Choose connection'
+      name: 'Choose connection',
     },
     {
       key: 'chooseTrigger',
@@ -28,17 +27,17 @@ export default defineTrigger({
             arguments: [
               {
                 name: 'key',
-                value: 'listAlbums'
-              }
-            ]
-          }
-        }
-      ]
+                value: 'listAlbums',
+              },
+            ],
+          },
+        },
+      ],
     },
     {
       key: 'testStep',
-      name: 'Test trigger'
-    }
+      name: 'Test trigger',
+    },
   ],
 
   async run($) {
diff --git a/packages/backend/src/apps/flickr/triggers/new-photos/index.ts b/packages/backend/src/apps/flickr/triggers/new-photos/index.ts
index 41d7e5e3..663bf8a2 100644
--- a/packages/backend/src/apps/flickr/triggers/new-photos/index.ts
+++ b/packages/backend/src/apps/flickr/triggers/new-photos/index.ts
@@ -6,16 +6,15 @@ export default defineTrigger({
   pollInterval: 15,
   key: 'newPhotos',
   description: 'Triggers when you add a new photo.',
-  dedupeStrategy: 'greatest',
   substeps: [
     {
       key: 'chooseConnection',
-      name: 'Choose connection'
+      name: 'Choose connection',
     },
     {
       key: 'testStep',
-      name: 'Test trigger'
-    }
+      name: 'Test trigger',
+    },
   ],
 
   async run($) {
diff --git a/packages/backend/src/apps/github/triggers/new-watchers/index.ts b/packages/backend/src/apps/github/triggers/new-watchers/index.ts
index 03204e7f..a583c1f2 100644
--- a/packages/backend/src/apps/github/triggers/new-watchers/index.ts
+++ b/packages/backend/src/apps/github/triggers/new-watchers/index.ts
@@ -5,7 +5,6 @@ export default defineTrigger({
   name: 'New watchers',
   key: 'newWatchers',
   pollInterval: 15,
-  dedupeStrategy: 'unique',
   description: 'Triggers when a user watches a repository',
   substeps: [
     {
diff --git a/packages/backend/src/apps/twitter/triggers/new-follower-of-me/index.ts b/packages/backend/src/apps/twitter/triggers/new-follower-of-me/index.ts
index 19adfd6c..4ce76592 100644
--- a/packages/backend/src/apps/twitter/triggers/new-follower-of-me/index.ts
+++ b/packages/backend/src/apps/twitter/triggers/new-follower-of-me/index.ts
@@ -6,7 +6,6 @@ export default defineTrigger({
   key: 'myFollowers',
   pollInterval: 15,
   description: 'Will be triggered when you have a new follower.',
-  dedupeStrategy: 'unique',
   substeps: [
     {
       key: 'chooseConnection',
diff --git a/packages/types/index.d.ts b/packages/types/index.d.ts
index d2e337f3..16736dfa 100644
--- a/packages/types/index.d.ts
+++ b/packages/types/index.d.ts
@@ -210,7 +210,6 @@ export interface ITrigger {
   key: string;
   pollInterval?: number;
   description: string;
-  dedupeStrategy?: 'greatest' | 'unique' | 'last';
   substeps: ISubstep[];
   getInterval?(parameters: IStep['parameters']): string;
   run($: IGlobalVariable): Promise<void>;