From 1bcaec144b5f2f44881e8ed37df726d8d1458675 Mon Sep 17 00:00:00 2001
From: Ali BARIN <ali.barin53@gmail.com>
Date: Tue, 10 Sep 2024 10:15:59 +0000
Subject: [PATCH] test(create-step): use non-admin user

---
 .../api/v1/flows/create-step.test.js          | 16 +++-
 packages/backend/test/factories/role.js       | 79 -------------------
 2 files changed, 13 insertions(+), 82 deletions(-)

diff --git a/packages/backend/src/controllers/api/v1/flows/create-step.test.js b/packages/backend/src/controllers/api/v1/flows/create-step.test.js
index 358831dd..4d90dfba 100644
--- a/packages/backend/src/controllers/api/v1/flows/create-step.test.js
+++ b/packages/backend/src/controllers/api/v1/flows/create-step.test.js
@@ -5,7 +5,6 @@ import request from 'supertest';
 import app from '../../../../app.js';
 import createAuthTokenByUserId from '../../../../helpers/create-auth-token-by-user-id.js';
 import { createUser } from '../../../../../test/factories/user.js';
-import { createAdminRole } from '../../../../../test/factories/role.js';
 import { createFlow } from '../../../../../test/factories/flow.js';
 import { createStep } from '../../../../../test/factories/step.js';
 import createStepMock from '../../../../../test/mocks/rest/api/v1/flows/create-step.js';
@@ -15,8 +14,19 @@ describe('POST /api/v1/flows/:flowId/steps', () => {
   let currentUser, flow, triggerStep, token;
 
   beforeEach(async () => {
-    const adminRole = await createAdminRole();
-    currentUser = await createUser({ roleId: adminRole.id });
+    currentUser = await createUser();
+
+    await createPermission({
+      roleId: currentUser.roleId,
+      subject: 'Flow',
+      action: 'read',
+    });
+
+    await createPermission({
+      roleId: currentUser.roleId,
+      subject: 'Flow',
+      action: 'update',
+    });
 
     flow = await createFlow({ userId: currentUser.id });
 
diff --git a/packages/backend/test/factories/role.js b/packages/backend/test/factories/role.js
index 3d3b165a..28ac9960 100644
--- a/packages/backend/test/factories/role.js
+++ b/packages/backend/test/factories/role.js
@@ -1,6 +1,5 @@
 import { faker } from '@faker-js/faker';
 import Role from '../../src/models/role';
-import { createPermission } from './permission';
 
 export const createRole = async (params = {}) => {
   const name = faker.lorem.word();
@@ -17,81 +16,3 @@ export const createRole = async (params = {}) => {
 
   return role;
 };
-
-export const createAdminRole = async (params = {}) => {
-  const adminRole = await createRole({ ...params, name: 'Admin' });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'read',
-    subject: 'Flow',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'create',
-    subject: 'Flow',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'update',
-    subject: 'Flow',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'delete',
-    subject: 'Flow',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'publish',
-    subject: 'Flow',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'read',
-    subject: 'Connection',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'create',
-    subject: 'Connection',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'update',
-    subject: 'Connection',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'delete',
-    subject: 'Connection',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'read',
-    subject: 'Execution',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'create',
-    subject: 'Execution',
-  });
-
-  await createPermission({
-    roleId: adminRole.id,
-    action: 'update',
-    subject: 'Execution',
-  });
-
-  return adminRole;
-};