From 0784a2d4d09eaf8ddbe8a2a2e1a12d35569fe76b Mon Sep 17 00:00:00 2001 From: Faruk AYDIN Date: Tue, 6 Jun 2023 11:41:02 +0200 Subject: [PATCH] refactor: Use limit to prevent fetching all records --- packages/backend/src/models/flow.ts | 1 + packages/backend/src/models/step.ts | 1 + packages/backend/src/models/user.ts | 4 ++-- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/backend/src/models/flow.ts b/packages/backend/src/models/flow.ts index 14268192..5ae48d6c 100644 --- a/packages/backend/src/models/flow.ts +++ b/packages/backend/src/models/flow.ts @@ -91,6 +91,7 @@ class Flow extends Base { async lastInternalId() { const lastExecution = await this.$relatedQuery('executions') .orderBy('created_at', 'desc') + .limit(1) .first(); return lastExecution ? (lastExecution as Execution).internalId : null; diff --git a/packages/backend/src/models/step.ts b/packages/backend/src/models/step.ts index 2815df7b..b46853ba 100644 --- a/packages/backend/src/models/step.ts +++ b/packages/backend/src/models/step.ts @@ -117,6 +117,7 @@ class Step extends Base { async getLastExecutionStep() { const lastExecutionStep = await this.$relatedQuery('executionSteps') .orderBy('created_at', 'desc') + .limit(1) .first(); return lastExecutionStep; diff --git a/packages/backend/src/models/user.ts b/packages/backend/src/models/user.ts index d5b4f0d3..e0bfdf42 100644 --- a/packages/backend/src/models/user.ts +++ b/packages/backend/src/models/user.ts @@ -102,7 +102,7 @@ class User extends Base { to: 'users.id', }, filter(builder: ExtendedQueryBuilder) { - builder.orderBy('created_at', 'desc').first(); + builder.orderBy('created_at', 'desc').limit(1).first(); }, }, subscriptions: { @@ -121,7 +121,7 @@ class User extends Base { to: 'users.id', }, filter(builder: ExtendedQueryBuilder) { - builder.orderBy('created_at', 'desc').first(); + builder.orderBy('created_at', 'desc').limit(1).first(); }, }, });